[Intel-wired-lan] [PATCH] intel: i40evf: Replace GFP_ATOMIC with GFP_KERNEL in i40evf_add_vlan

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jia-Ju Bai
> Sent: Tuesday, April 10, 2018 7:08 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
> Cc: netdev at vger.kernel.org; Jia-Ju Bai <baijiaju1990 at gmail.com>; intel-
> wired-lan at lists.osuosl.org; linux-kernel at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] intel: i40evf: Replace GFP_ATOMIC with
> GFP_KERNEL in i40evf_add_vlan
> 
> i40evf_add_vlan() is never called in atomic context.
> 
> i40evf_add_vlan() is only called by i40evf_vlan_rx_add_vid(), which is only
> set as ".ndo_vlan_rx_add_vid" in struct net_device_ops.
> ".ndo_vlan_rx_add_vid" is not called in atomic context.
> 
> Despite never getting called from atomic context,
> i40evf_add_vlan() calls kzalloc() with GFP_ATOMIC, which does not sleep for
> allocation.
> GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which
> can sleep and improve the possibility of sucessful allocation.
> 
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990 at gmail.com>
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>