[Intel-wired-lan] [PATCH v2] ice: Do not check INTEVENT bit for OICR interrupts

Brelinski, TonyX tonyx.brelinski at intel.com
Tue Apr 17 21:21:51 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Wednesday, April 11, 2018 12:22 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v2] ice: Do not check INTEVENT bit for OICR
> interrupts
> 
> From: Ben Shelton <benjamin.h.shelton at intel.com>
> 
> According to the hardware spec, checking the INTEVENT bit isn't a reliable
> way to detect if an OICR interrupt has occurred. This is because this bit can be
> cleared by the hardware/firmware before the interrupt service routine has
> run. So instead, just check for OICR events everytime.
> 
> Fixes: 940b61af02f4 ("ice: Initialize PF and setup miscellaneous
> interrupt")
> 
> Signed-off-by: Ben Shelton <benjamin.h.shelton at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> 
> ---
> v2: Add credits to the original author and fix formatting for "Fixes"
> ---
>  drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 2 --
>  drivers/net/ethernet/intel/ice/ice_main.c       | 4 ----
>  2 files changed, 6 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski at intel.com>




More information about the Intel-wired-lan mailing list