[Intel-wired-lan] [PATCH] ixgbe: Fix free irq process when removing device due to PCI Errors]
Guilherme G. Piccoli
kernel at gpiccoli.net
Wed Apr 18 18:14:14 UTC 2018
Thanks Mauro, nice fix! A minor suggestion below.
Other than that, feel free to add:
Reviewed-by: Guilherme G. Piccoli <kernel at gpiccoli.net>
>
> [...]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index afadba9..d170de8 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -6679,7 +6679,8 @@ int ixgbe_close(struct net_device *netdev)
>
> ixgbe_ptp_stop(adapter);
>
> - if (netif_device_present(netdev))
> + if (netif_device_present(netdev) ||
> + adapter->pdev->error_state == pci_channel_io_perm_failure)
How about using pci_channel_offline() here instead of manually
checking the error_state flag? It's a minor though heheh
Cheers,
Guilherme
> ixgbe_close_suspend(adapter);
>
> ixgbe_fdir_filter_exit(adapter);
>
More information about the Intel-wired-lan
mailing list