[Intel-wired-lan] [PATCH] ixgbe: fix memory leak on ipsec allocation

Bowers, AndrewX andrewx.bowers at intel.com
Thu May 10 19:14:00 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Colin King
> Sent: Wednesday, May 9, 2018 6:59 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>; David S . Miller
> <davem at davemloft.net>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org
> Cc: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] ixgbe: fix memory leak on ipsec allocation
> 
> From: Colin Ian King <colin.king at canonical.com>
> 
> The error clean up path kfree's adapter->ipsec and should be instead
> kfree'ing ipsec. Fix this.  Also, the err1 error exit path does not need to kfree
> ipsec because this failure path was for the failed allocation of ipsec.
> 
> Detected by CoverityScan, CID#146424 ("Resource Leak")
> 
> Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list