[Intel-wired-lan] [PATCH v4 1/1] drivers core: multi-threading device shutdown

Pavel Tatashin pasha.tatashin at oracle.com
Tue May 15 12:21:03 UTC 2018


Hi Greg,

> Can you refactor this to be at least 2 patches?  One that moves code
> around to comon functions to make the second patch, that adds the new
> functionality, easier to review and understand?

Yes, I will split the patch into a two-three patches.


> And I echo the "don't use kerneldoc for static functions" review
> comment, that's not needed at all.

It was my mistake, I did not realize they were kerneldoc, I simply tried to
follow the code style of this file :) I will modify comments not to be
kerneldoc.

Thank you,
Pavel


More information about the Intel-wired-lan mailing list