[Intel-wired-lan] [PATCH v2 2/2] ena: Fix settings/advertising for ethtool

Jeff Kirsher jeffrey.t.kirsher at intel.com
Tue May 15 18:01:55 UTC 2018


It appears that the Amazon Ethernet driver was setting bits in the
'settings' field twice.  Almost certainly this was supposed to set bits in
the 'advertising' field instead.

CC: Mitch Williams <mitch.a.williams at intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
---
 drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
index 0a4de911e6cc..2f5e4cf84934 100644
--- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
+++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
@@ -283,7 +283,7 @@ static int ena_get_link_ksettings(struct net_device *netdev,
 
 	if (link->flags & ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK) {
 		ethtool_ks_add_mode(link_ksettings, supported, Autoneg);
-		ethtool_ks_add_mode(link_ksettings, supported, Autoneg);
+		ethtool_ks_add_mode(link_ksettings, advertising, Autoneg);
 	}
 
 	link_ksettings->base.autoneg =
-- 
2.17.0



More information about the Intel-wired-lan mailing list