[Intel-wired-lan] [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

Bowers, AndrewX andrewx.bowers at intel.com
Tue May 15 22:53:56 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Pavel Tatashin
> Sent: Wednesday, May 2, 2018 9:00 PM
> To: pasha.tatashin at oracle.com; steven.sistare at oracle.com;
> daniel.m.jordan at oracle.com; linux-kernel at vger.kernel.org; Kirsher, Jeffrey
> T <jeffrey.t.kirsher at intel.com>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org; gregkh at linuxfoundation.org
> Subject: [Intel-wired-lan] [PATCH 1/2] ixgbe: release lock for the duration of
> ixgbe_suspend_close()
> 
> Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of
> lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this
> lock prevents scaling if device_shutdown() function is multi-threaded.
> 
> It is not necessary to hold this lock during ixgbe_close_suspend() as it is not
> held when ixgbe_close() is called also during shutdown but for kexec case.
> 
> Signed-off-by: Pavel Tatashin <pasha.tatashin at oracle.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list