[Intel-wired-lan] [net-queue PATCH] ixgbe: Move ipsec init function to before reset call

[Alexander Duyck]

On Mon, Jun 4, 2018 at 11:07 AM, Alexander Duyck
<alexander.duyck at gmail.com> wrote:
> On Mon, Jun 4, 2018 at 10:34 AM, Shannon Nelson
> <shannon.nelson at oracle.com> wrote:
>> On 6/4/2018 9:24 AM, Alexander Duyck wrote:
>>>
>>> This patch moves the ipsec init function in ixgbe_sw_init. This way it is
>>> a
>>> bit more consistent with the placement of similar initialization functions
>>> and is placed before the reset_hw call which should allow us to clean up
>>> any link issues that may be introduced by the fact that we force the link
>>> up if somehow the device had ipsec still enabled before the driver was
>>> loaded.
>>>
>>> Fixes: 49a94d74d948 ("ixgbe: add ipsec engine start and stop routines")
>>> Reported-by: Andre Tomt <andre at tomt.net>
>>> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
>>> ---
>>
>>
>> NAK - this won't work for the simple reason that the netdev feature flags
>> that ixgbe_init_ipsec_offload() sets will get bashed later when probe()
>> starts setting netdev feature flags.
>
> Yeah, I realized that after I started doing any testing. I was already
> working on a v2 to address that as we could pull the feature bit
> setting out and place it with the other features and only enable it
> based on if adapter->ipsec is set or not.

Jeff,

Please drop this patch. I will work with Shannon to make sure we have
a more complete solution.

Thanks.

- Alex