[Intel-wired-lan] [jkirsher/net-queue PATCH] ixgbe: Be more careful when modifying MAC filters

Bowers, AndrewX andrewx.bowers at intel.com
Wed Jun 20 17:23:48 UTC 2018

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Monday, June 18, 2018 9:02 AM
> To: shannon.nelson at oracle.com; Fujinaka, Todd
> <todd.fujinaka at intel.com>; intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey
> T <jeffrey.t.kirsher at intel.com>
> Subject: [Intel-wired-lan] [jkirsher/net-queue PATCH] ixgbe: Be more careful
> when modifying MAC filters
> This change makes it so that we are much more explicit about the ordering of
> updates to the receive address register (RAR) table. Prior to this patch I
> believe we may have been updating the table while entries were still active,
> or possibly allowing for reordering of things since we weren't explicitly
> flushing writes to either the lower or upper portion of the register prior to
> accessing the other half.
> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> ---
> I am submitting this as a fix, but I am not certain this actually fixes anything or
> if it is more of just a clean-up. I know there have been some issues with MAC
> address updates reported recently so I decided to review the code and
> found the bits here that I thought needed to be updated.
> Especially the case where we were clearing the lower 32b of the address with
> AV still set in the upper 32b of the register.
>  drivers/net/ethernet/intel/ixgbe/ixgbe_common.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>

More information about the Intel-wired-lan mailing list