[Intel-wired-lan] [PATCH] fq_codel: fix NULL pointer deref in fq_codel_reset

[Keller, Jacob E]

> -----Original Message-----
> From: Eric Dumazet [mailto:edumazet at google.com]
> Sent: Friday, June 08, 2018 8:01 AM
> To: Keller, Jacob E <jacob.e.keller at intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>
> Subject: Re: [PATCH] fq_codel: fix NULL pointer deref in fq_codel_reset
> 
> Not sure this is the right fix.
> 
> It is very strange that
> 
> ->init()   (failure) -> reset()  ,  then ->destroy()
> 
> Why reset() is called before a destroy, I have no idea.
> 
> Anyway you must send patches to netdev@
> 
> Thanks.

If you have a better suggestion, I'm all ears.

I've heard that we should set qflows_cnt to 0 instead of checking the null pointer directly. I'm fine with that solution too.

I'd be fine removing the reset() call also, if you think that's better. I don't know if that would adversely impact the other schedulers though.

Thanks,
Jake