[Intel-wired-lan] [PATCH net] ixgbe: Off by one in ixgbe_ipsec_tx()
Shannon Nelson
shannon.nelson at oracle.com
Mon Jul 9 15:53:23 UTC 2018
On 7/4/2018 2:53 AM, Dan Carpenter wrote:
> The ipsec->tx_tbl[] has IXGBE_IPSEC_MAX_SA_COUNT elements so the > needs
> to be changed to >= so we don't read one element beyond the end of the
> array.
>
> Fixes: 592594704761 ("ixgbe: process the Tx ipsec offload")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Acked-by: Shannon Nelson <shannon.nelson at oracle.com>
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> index c116f459945d..da4322e4daed 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> @@ -839,7 +839,7 @@ int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,
> }
>
> itd->sa_idx = xs->xso.offload_handle - IXGBE_IPSEC_BASE_TX_INDEX;
> - if (unlikely(itd->sa_idx > IXGBE_IPSEC_MAX_SA_COUNT)) {
> + if (unlikely(itd->sa_idx >= IXGBE_IPSEC_MAX_SA_COUNT)) {
> netdev_err(tx_ring->netdev, "%s: bad sa_idx=%d handle=%lu\n",
> __func__, itd->sa_idx, xs->xso.offload_handle);
> return 0;
>
More information about the Intel-wired-lan
mailing list