[Intel-wired-lan] [PATCH v6 03/11] igc: Add netdev

[Shannon Nelson]

On 8/23/2018 12:05 AM, Sasha Neftin wrote:

[...]

> +	strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);

[...]

> +	strncpy(netdev->name, "eth%d", IFNAMSIZ);

I've mentioned this to you before: why are you setting the netdev->name 
twice, and to different values?  Besides, the OS's udev rules will 
likely change the name to something else.


> +
> +module_param(debug, int, 0);
> +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>   /* igc_main.c */

It would be nice to have this up above, next to the definition of int debug.

sln