[Intel-wired-lan] [PATCH 3/5] ixgbe: add AF_XDP zero-copy Rx support

Björn Töpel bjorn.topel at gmail.com
Wed Sep 26 14:29:42 UTC 2018


Den tis 25 sep. 2018 kl 16:57 skrev Jakub Kicinski
<jakub.kicinski at netronome.com>:
>
> On Mon, 24 Sep 2018 18:35:55 +0200, Björn Töpel wrote:
> > +     if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
> > +             return -EINVAL;
> > +
> > +     if (adapter->flags & IXGBE_FLAG_DCB_ENABLED)
> > +             return -EINVAL;
>
> Hm, should you add UMEM checks to all the places these may get
> enabled?  Like fabf1bce103a ("ixgbe: Prevent unsupported configurations
> with XDP") did?

Actually, I can remove these checks, since it's already checked by the
XDP path. AF_XDP ZC is enabled only when XDP is enabled. So there's no
need to have the XDP checks in the AF_XDP path.

Björn


More information about the Intel-wired-lan mailing list