[Intel-wired-lan] [PATCH 8/8] ice: fix changing of ring descriptor size (ethtool -G)

Bowers, AndrewX andrewx.bowers at intel.com
Wed Sep 26 16:43:51 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Wednesday, September 19, 2018 5:23 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH 8/8] ice: fix changing of ring descriptor size
> (ethtool -G)
> 
> From: Bruce Allan <bruce.w.allan at intel.com>
> 
> rx_mini_pending was set to an incorrect value. This was causing EINVAL to
> always be returned to 'ethtool -G'. The driver does not support mini or
> jumbo rings so the respective settings should be zero.
> 
> Also, change the valid range of the number of descriptors in the rings to
> make the code simpler and easier for users to understand (this removes the
> valid settings of 8 and 16). Add a system log message indicating when the
> number is rounded-up from what the user specifies with the 'ethtool -G'
> command (i.e. when it is not a multiple of 32), and update the log message
> when a user-provided value is out of range to also indicate the stride.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h         |  4 ++--
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 17 ++++++++++++++---
>  2 files changed, 16 insertions(+), 5 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list