[Intel-wired-lan] [PATCH v2 13/16] ice: Add more flexibility on how we assign an ITR index

Bowers, AndrewX andrewx.bowers at intel.com
Wed Sep 26 17:08:30 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Wednesday, September 19, 2018 5:43 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v2 13/16] ice: Add more flexibility on how
> we assign an ITR index
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> This issue came about when looking at the VF function
> ice_vc_cfg_irq_map_msg. Currently we are assigning the itr_setting value to
> the itr_idx received from the AVF driver, which is not correct and is not used
> for the VF flow anyway. Currently the only way we set the ITR index for both
> the PF and VF driver is by hardcoding ICE_TX_ITR or ICE_RX_ITR for the ITR
> index on each q_vector.
> 
> To fix this, add the member itr_idx in struct ice_ring_container. Thisi can then
> be used to dynamically program the correct ITR index. This change also
> affected the PF driver so make the necessary changes there as well.
> 
> Also, removed the itr_setting member in struct ice_ring because it is not
> being used meaningfully and is going to be removed in a future patch that
> includes dynamic itr.
> 
> On another note, this will be useful moving forward if we decide to split rx/tx
> rings on different q_vectors instead of sharing them as queue pairs.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
> [Anirudh Venkataramanan <anirudh.venkataramanan at intel.com> cleaned
> up commit message]
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c         | 73 ++++++++++++++----------
>  drivers/net/ethernet/intel/ice/ice_txrx.h        | 13 ++---
>  drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 20 ++++---
>  3 files changed, 59 insertions(+), 47 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list