[Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment

Shannon Nelson shannon.nelson at oracle.com
Fri Oct 5 18:42:30 UTC 2018


On 10/4/2018 3:18 PM, Alice Michael wrote:
> From: Patryk Małek <patryk.malek at intel.com>
> 
> Found by upstream review.  It also fixes a minor comment formatting
> to adhere to networking comment formatting.

As far as I can tell, this doesn't apply to what I can see in Jeff's 
tree.  Also, I don't see anything about comment formatting in this patch.

sln

> 
> Signed-off-by: Patryk Małek <patryk.malek at intel.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index f35a26c..2bb116f 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -4958,8 +4958,8 @@ void i40e_set_ethtool_ops(struct net_device *netdev)
>   	struct i40e_netdev_priv *np = netdev_priv(netdev);
>   	struct i40e_pf		*pf = np->vsi->back;
>   
> -	if (!test_bit(__I40E_RECOVERY_MODE, pf->state))
> -		netdev->ethtool_ops = &i40e_ethtool_ops;
> -	else
> +	if (test_bit(__I40E_RECOVERY_MODE, pf->state))
>   		netdev->ethtool_ops = &i40e_ethtool_recovery_mode_ops;
> +	else
> +		netdev->ethtool_ops = &i40e_ethtool_ops;
>   }
> 


More information about the Intel-wired-lan mailing list