[Intel-wired-lan] [PATCH S8 11/16] ice: Fix debug print in ice_tx_timeout

Bowers, AndrewX andrewx.bowers at intel.com
Tue Oct 30 22:01:03 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Friday, October 26, 2018 10:41 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S8 11/16] ice: Fix debug print in
> ice_tx_timeout
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently the debug print in ice_tx_timeout is printing useless and duplicate
> values. First, head is being assigned to tx_ring->next_to_clean and we are
> printing both of those values, but naming them HWB and NTC respectively.
> Also, reading tail always returns 0 so remove that as well.
> 
> Instead of assigning head the SW head (NTC) read the actual head register
> and change the debug print to note that this is HW_HEAD. Also reduce thei
> scope of a couple variables.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
> [Anirudh Venkataramanan <anirudh.venkataramanan at intel.com> cleaned
> up commit message]
> ---
>  drivers/net/ethernet/intel/ice/ice_hw_autogen.h |  3 +++
>  drivers/net/ethernet/intel/ice/ice_main.c       | 15 +++++++++------
>  2 files changed, 12 insertions(+), 6 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list