[Intel-wired-lan] [next PATCH S98 6/6] i40e: suppress bogus error message

Bowers, AndrewX andrewx.bowers at intel.com
Wed Oct 31 16:28:13 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alice Michael
> Sent: Friday, October 26, 2018 2:34 PM
> To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S98 6/6] i40e: suppress bogus error
> message
> 
> From: Mitch Williams <mitch.a.williams at intel.com>
> 
> The i40e driver complains about unprivileged VFs trying to configure
> promiscuous mode each time a VF reset occurs. This isn't the fault of the
> poor VF driver - the PF driver itself is making the request.
> 
> To fix this, skip the privilege check if the request is to disable all promiscuous
> activity. This gets rid of the bogus message, but doesn't affect privilege
> checks, since we really only care if the unprivileged VF is trying to enable
> promiscuous mode.
> 
> Testing Hints (required if no HSD): watch dmesg log while VF resets occur.
> You can trigger a VFR by unloading i40evf or shutting down the VM with an
> assigned VF.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list