[Intel-wired-lan] [PATCH] e1000e: fix a missing check for return value
Jeff Kirsher
jeffrey.t.kirsher at intel.com
Fri Jan 4 01:12:20 UTC 2019
On Thu, 2019-01-03 at 15:54 -0800, Jeff Kirsher wrote:
> The change is based on the issue found by Kangjie Lu <kjlu at umn.edu>
> where
> we not checking the return value of a register read/write which could
> result
> in a NULL pointer dereference if the read/write fails.
>
> Since we are only trying to disable the far-end loopback, if the read
> and write of register fails, we do not want to bail out of the
> function.
> We just want to log that it failed to disable and continue on.
>
> CC: Sasha Neftin <sasha.neftin at intel.com>
> CC: Kangjie Lu <kjlu at umn.edu>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> ---
> .../net/ethernet/intel/e1000e/80003es2lan.c | 31 +++++++++++++--
> ----
> 1 file changed, 21 insertions(+), 10 deletions(-)
v2 coming, I fat fingered a typo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190103/6edd4350/attachment.asc>
More information about the Intel-wired-lan
mailing list