[Intel-wired-lan] [next PATCH S2 09/13] i40e: [NVMUpdate] kernel crash after unloading i40e driver

Alice Michael alice.michael at intel.com
Wed Feb 6 19:36:18 UTC 2019


From: Piotr Marczak <piotr.marczak at intel.com>

After NVMUpdate driver is in Recovery Mode and performing reset but
i40e_client is still up. If there is an activity on port which already
is down and its dereference is NULL, client would still dispatch
processing to this PF causing hard kernel crash. This fix prevents
such a situation.

Signed-off-by: Piotr Marczak <piotr.marczak at intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index c4eb212d794b..8e51a77ac5f6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -14983,7 +14983,6 @@ static void i40e_remove(struct pci_dev *pdev)
 	 * has been stopped.
 	 */
 	i40e_notify_client_of_netdev_close(pf->vsi[pf->lan_vsi], false);
-
 	if (pf->flags & I40E_FLAG_SRIOV_ENABLED) {
 		i40e_free_vfs(pf);
 		pf->flags &= ~I40E_FLAG_SRIOV_ENABLED;
-- 
2.19.2



More information about the Intel-wired-lan mailing list