[Intel-wired-lan] [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static

Neftin, Sasha sasha.neftin at intel.com
Sun Feb 17 10:06:21 UTC 2019


On 2/16/2019 04:04, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning:
>   symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
> 
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index eff37a6c0afa..544239422577 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
>   	return 0;
>   }
>   
> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>   {
>   	struct igc_hw *hw = &adapter->hw;
>   	u32 reg = IGC_RETA(0);
> 
> 
> NACK
'igc_write_rss_indir_tbl' method declared in igc.h file. This method 
used in both igc_ethtool.c and igc_main.c and can't be a 'static'


More information about the Intel-wired-lan mailing list