[Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Mukesh Ojha]

On 3/9/2019 9:01 AM, Kangjie Lu wrote:
> If ixgbevf_write_msg_read_ack fails, return its error code upstream
>
> Signed-off-by: Kangjie Lu <kjlu at umn.edu>
> ---
>   drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
> index cd3b81300cc7..d5ce49636548 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/vf.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
> @@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
>   		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
>   	}
>   
> -	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
> -
> -	return 0;
> +	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
> +			IXGBE_VFMAILBOX_SIZE);


Reviewed-by: Mukesh Ojha <mojha at codeaurora.org 
<mailto:mojha at codeaurora.org>>

Thanks,
Mukesh

>   }
>   
>   /**
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190322/eecc7cca/attachment.html>