[Intel-wired-lan] [PATCH] net: fm10k: fix a potential NULL pointer dereference

Kangjie Lu kjlu at umn.edu
Sat Mar 23 03:26:37 UTC 2019



> On Mar 11, 2019, at 1:17 AM, Kangjie Lu <kjlu at umn.edu> wrote:
> 
> In case alloc_workqueue fails, the fix returns -ENOMEM to avoid
> potential NULL pointer dereference.
> 
> Signed-off-by: Kangjie Lu <kjlu at umn.edu>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> index 5a0419421511..215f232674f1 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> @@ -41,6 +41,8 @@ static int __init fm10k_init_module(void)
> 	/* create driver workqueue */
> 	fm10k_workqueue = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
> 					  fm10k_driver_name);
> +	if (unlikely(!fm10k_workqueue))
> +		return -ENOMEM;
> 

Jeff, can you review this patch?

Thanks.

> 	fm10k_dbg_init();
> 
> -- 
> 2.17.1
> 



More information about the Intel-wired-lan mailing list