[Intel-wired-lan] [PATCH S18 06/15] ice: Always free/allocate q_vectors

Bowers, AndrewX andrewx.bowers at intel.com
Fri Apr 26 20:35:03 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Tuesday, April 16, 2019 10:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S18 06/15] ice: Always free/allocate
> q_vectors
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently when probing/removing the driver we allocate/deallocate each vsi-
> >q_vectors array in ice_vsi_alloc_arrays() and
> ice_vsi_free_arrays() respectively. However, we don't do this during the
> reset and VSI rebuild flow. This is inconsistent and unnecessary to have a
> difference between the two flows.
> 
> This patch makes the change to always allocate/deallocate the
> vsi->q_vectors array regardless of the driver flow we are in.
> 
> Also, update the comment for ice_vsi_free_arrays() to be more descriptive.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 34 ++++++++++--------------
>  1 file changed, 14 insertions(+), 20 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list