[Intel-wired-lan] [PATCH S19 10/15] ice: Reorganize tx_buf and ring structs

Bowers, AndrewX andrewx.bowers at intel.com
Fri Apr 26 22:00:13 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Tuesday, April 16, 2019 10:25 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S19 10/15] ice: Reorganize tx_buf and ring
> structs
> 
> From: Jesse Brandeburg <jesse.brandeburg at intel.com>
> 
> Use more efficient structure ordering by using the pahole tool and a lot of
> code inspection to get hot cache lines to have packed data (no holes if
> possible) and adjacent warm data.
> 
> ice_ring prior to this change:
>   /* size: 192, cachelines: 3, members: 23 */
>   /* sum members: 158, holes: 4, sum holes: 12 */
>   /* padding: 22 */
> 
> ice_ring after this change:
>   /* size: 192, cachelines: 3, members: 25 */
>   /* sum members: 162, holes: 1, sum holes: 1 */
>   /* padding: 29 */
> 
> ice_tx_buf prior to this change:
>   /* size: 48, cachelines: 1, members: 7 */
>   /* sum members: 38, holes: 2, sum holes: 6 */
>   /* padding: 4 */
>   /* last cacheline: 48 bytes */
> 
> ice_tx_buf after this change:
>   /* size: 40, cachelines: 1, members: 7 */
>   /* sum members: 38, holes: 1, sum holes: 2 */
>   /* last cacheline: 40 bytes */
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
> [Anirudh Venkataramanan <anirudh.venkataramanan at intel.com> cleaned
> up commit message]
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.h | 35 ++++++++++++++---------
>  1 file changed, 21 insertions(+), 14 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list