[Intel-wired-lan] [PATCH S19 13/15] ice: Fix couple of issues in ice_vsi_release

Bowers, AndrewX andrewx.bowers at intel.com
Fri Apr 26 22:01:49 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Tuesday, April 16, 2019 10:25 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S19 13/15] ice: Fix couple of issues in
> ice_vsi_release
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently the driver is calling ice_napi_del() and then unregister_netdev().
> The call to unregister_netdev() will result in a call to ice_stop() and then
> ice_vsi_close(). This is where we call
> napi_disable() for all the MSI-X vectors. This flow is reversed so make the
> changes to ensure napi_disable() happens prior to napi_del().
> 
> Before calling napi_del() and free_netdev() make sure
> unregister_netdev() was called. This is done by making sure the
> __ICE_DOWN bit is set in the vsi->state for the interested VSI.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h      |  1 -
>  drivers/net/ethernet/intel/ice/ice_lib.c  | 24 ++++++++++++-----------
> drivers/net/ethernet/intel/ice/ice_main.c |  2 +-
>  3 files changed, 14 insertions(+), 13 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list