[Intel-wired-lan] [PATCH S19 08/15] ice: Gracefully handle reset failure in ice_alloc_vfs()

Bowers, AndrewX andrewx.bowers at intel.com
Tue Apr 30 23:20:00 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anirudh Venkataramanan
> Sent: Tuesday, April 16, 2019 10:25 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S19 08/15] ice: Gracefully handle reset
> failure in ice_alloc_vfs()
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently if ice_reset_all_vfs() fails in ice_alloc_vfs() we fail to free some
> resources, reset variables, and return an error value.
> Fix this by adding another unroll case to free the pf->vf array, set the pf-
> >num_alloc_vfs to 0, and return an error code.
> 
> Without this, if ice_reset_all_vfs() fails in ice_alloc_vfs() we will not be able
> to do SRIOV without hard rebooting the system because rmmoding the
> driver does not work.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list