[Intel-wired-lan] [next PATCH S5 06/10] i40e: add input validation for virtchnl handlers

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alice Michael
> Sent: Wednesday, April 24, 2019 5:21 AM
> To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S5 06/10] i40e: add input validation for
> virtchnl handlers
> 
> From: Sergey Nemov <sergey.nemov at intel.com>
> 
> Change some data to unsigned int instead of integer when we compare.
> 
> Check LUT values in VIRTCHNL_OP_CONFIG_RSS_LUT handler.
> 
> Also enhance error/warning messages to print the real values of
> I40E_MAX_VF_QUEUES, I40E_MAX_VF_VSI and
> I40E_DEFAULT_QUEUES_PER_VF instead of plain text.
> 
> Refactor code to comply with 'check first then assign' policy.
> 
> Remove duplicate checks for VIRTCHNL_OP_CONFIG_RSS_KEY and
> VIRTCHNL_OP_CONFIG_RSS_LUT opcodes in i40e_vc_process_vf_msg(). We
> have the very same checks inside the handlers already.
> 
> Signed-off-by: Sergey Nemov <sergey.nemov at intel.com>
> ---
>  .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 74 ++++++++-----------
>  1 file changed, 31 insertions(+), 43 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>