[Intel-wired-lan] [PATCH 1/6] igb: mark expected switch fall-through

Gustavo A. R. Silva gustavo at embeddedor.com
Fri May 24 13:40:05 UTC 2019


On 5/16/19 2:17 PM, Jeff Kirsher wrote:
> On Wed, 2019-05-08 at 12:59 -0500, Gustavo A. R. Silva wrote:
>> Hi Jeff,
>> I wonder if there is any chance for this series to be queued up for
>> 5.2-rc1.
> Possibly, but since the nature of your patch is to just modify a code
> comment because the tools used to check are not sophisticated enough to
> realize the code comment already clearly states "Fall through ...", I
> do not feel this is *really* necessary to get into 'net'.  If I have
> other 'fixes' in my queue that need to get pushed, I may add this
> change to the series.  I have not decided yet whether it warrants being
> in 'net' or could wait till 'net-next'.

I get it, net-next is fine. However, I noticed this series is still in

There are only 6 of these fall-through warnings left in linux-next. Half
of them are fixed by this series. We want to add -Wimplicit-fallthrough
to the Makefile and start testing it in linux-next. And it'd be of great
help if you can move this series to your net-next/master, so it can be
merged into linux-next and be part of the test. :)


More information about the Intel-wired-lan mailing list