[Intel-wired-lan] [PATCH S22 08/16] ice: Only bump Rx tail and release buffers once per napi_poll

Bowers, AndrewX andrewx.bowers at intel.com
Tue Jul 2 22:53:48 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, June 26, 2019 2:20 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Creeley, Brett <brett.creeley at intel.com>
> Subject: [Intel-wired-lan] [PATCH S22 08/16] ice: Only bump Rx tail and
> release buffers once per napi_poll
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently we bump the Rx tail and release/give buffers to hardware every
> 16 descriptors. This causes us to bump Rx tail up to 4 times per napi_poll call.
> Also we are always bumping tail on an odd index and this is a problem
> because hardware ignores the lower 3 bits in the QRX_TAIL register. This is
> making it so hardware sees tail bumps only every 8 descriptors. Instead lets
> only bump Rx tail once per napi_poll if the value aligns with hardwares
> expectations of the lower 3 bits being cleared. Also only release/give Rx
> buffers once per napi_poll call.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 41 +++++++++++++++--------
>  1 file changed, 27 insertions(+), 14 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list