[Intel-wired-lan] [PATCH 13/19] fm10k: remove needless assignment of err local variable

Bowers, AndrewX andrewx.bowers at intel.com
Fri Jul 12 18:05:33 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Monday, July 8, 2019 4:13 PM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH 13/19] fm10k: remove needless
> assignment of err local variable
> 
> The local variable err in several functions in the fm10k_netdev.c file is
> initialized with a value that is never used. The err value is immediately re-
> assigned in all cases where it will be checked. Remove the unnecessary
> initializers.
> 
> This was detected by cppcheck and resolves the following warnings
> produced by that tool:
> 
> [fm10k_netdev.c:999] -> [fm10k_netdev.c:1004]: (style) Variable 'err' is
> reassigned a value before the old one has been used.
> 
> [fm10k_netdev.c:1019] -> [fm10k_netdev.c:1024]: (style) Variable 'err'
> is reassigned a value before the old one has been used.
> 
> [fm10k_netdev.c:64]: (style) Variable 'err' is assigned a value that is never
> used.
> 
> [fm10k_netdev.c:131]: (style) Variable 'err' is assigned a value that is never
> used.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list