[Intel-wired-lan] [PATCH] net: intel: Cleanup e1000 - add space between }}

Jeff Kirsher jeffrey.t.kirsher at intel.com
Mon Aug 26 08:03:33 UTC 2019


On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote:
> suggested by checkpatch
> 
> Signed-off-by: Forrest Fleming <ffleming at gmail.com>
> ---
>  .../net/ethernet/intel/e1000/e1000_param.c    | 28 +++++++++----------
>  1 file changed, 14 insertions(+), 14 deletions(-)

While I do not see an issue with this change, I wonder how important it is
to make such a change.  Especially since most of the hardware supported by
this driver is not available for testing.  In addition, this is one
suggested change by checkpatch.pl that I personally do not agree with.

This is not a hard NAK, but you have to explain how this change makes the
code more readable before I consider it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190826/db4fc78d/attachment.asc>


More information about the Intel-wired-lan mailing list