[Intel-wired-lan] [net-next 0/2] new PTP ioctl fixes
Jacob Keller
jacob.e.keller at intel.com
Wed Sep 25 23:33:10 UTC 2019
I noticed recently that Filip added new versions of the PTP ioctls which
correctly honor the reserved fields (making it so that we can safely extend
them in the future).
Unfortunately, this breaks the old ioctls for a couple of reasons. First,
the flags for the old ioctls get cleared. This means that the external
timestamp request can never be enabled. Further, it means future new flags
will *not* be cleared, and thus old ioctl will potentially send non-zero
data and be mis-interpreted.
Additionally, new flags are not protected against in-driver, because no
current driver verifies that the flags are only one of the supported ones.
This means new flags will be mis-interpreted by the drivers.
This series provides patches to fix drivers to verify and reject unsupported
flags, as well as to fix the ioctls to clear flags on the old version of the
ioctl properly.
Cc: Richard Cochran <richardcochran at gmail.com>
Cc: Felipe Balbi <felipe.balbi at linux.intel.com>
Cc: David S. Miller <davem at davemloft.net>
Cc: Christopher Hall <christopher.s.hall at intel.com>
Jacob Keller (2):
ptp: correctly disable flags on old ioctls
net: reject ptp requests with unsupported flags
drivers/net/dsa/mv88e6xxx/ptp.c | 5 +++++
drivers/net/ethernet/broadcom/tg3.c | 4 ++++
drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +++++++
.../ethernet/mellanox/mlx5/core/lib/clock.c | 10 +++++++++
drivers/net/ethernet/microchip/lan743x_ptp.c | 4 ++++
drivers/net/ethernet/renesas/ravb_ptp.c | 9 ++++++++
.../net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 ++++
drivers/net/phy/dp83640.c | 8 +++++++
drivers/ptp/ptp_chardev.c | 4 ++--
include/uapi/linux/ptp_clock.h | 22 +++++++++++++++++++
10 files changed, 76 insertions(+), 2 deletions(-)
--
2.23.0.245.gf157bbb9169d
More information about the Intel-wired-lan
mailing list