[Intel-wired-lan] [net-next v3 4/7] dp83640: reject unsupported external timestamp flags

Richard Cochran richardcochran at gmail.com
Sat Oct 12 18:28:56 UTC 2019


On Thu, Sep 26, 2019 at 11:11:06AM -0700, Jacob Keller wrote:
> Fix the dp83640 PTP support to explicitly reject any future flags that
> get added to the external timestamp request ioctl.
> 
> In order to maintain currently functioning code, this patch accepts all
> three current flags. This is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.

This driver has:

  flags                                                 Meaning                   
  ----------------------------------------------------  -------------------------- 
  PTP_ENABLE_FEATURE                                    Time stamp rising edge
  PTP_ENABLE_FEATURE|PTP_RISING_EDGE                    Time stamp rising edge
  PTP_ENABLE_FEATURE|PTP_FALLING_EDGE                   Time stamp falling edge
  PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE   Time stamp falling edge
 
> Cc: Stefan Sørensen <stefan.sorensen at spectralink.com>
> Cc: Richard Cochran <richardcochran at gmail.com>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>

Reviewed-by: Richard Cochran <richardcochran at gmail.com>


More information about the Intel-wired-lan mailing list