[Intel-wired-lan] [PATCH S32 05/15] ice: Fix to change Rx/Tx ring descriptor size via ethtool with DCBx

Bowers, AndrewX andrewx.bowers at intel.com
Fri Nov 1 16:42:38 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Friday, October 25, 2019 7:35 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S32 05/15] ice: Fix to change Rx/Tx ring
> descriptor size via ethtool with DCBx
> 
> From: Usha Ketineni <usha.k.ketineni at intel.com>
> 
> This patch fixes the call trace caused by the kernel when the Rx/Tx descriptor
> size change request is initiated via ethtool when DCB is configured.
> ice_set_ringparam() should use vsi->num_txq instead of
> vsi->alloc_txq as it represents the queues that are enabled in the
> driver when DCB is enabled/disabled. Otherwise, queue index being used
> can go out of range.
> 
> For example, when vsi->alloc_txq has 104 queues and with 3 TCS enabled via
> DCB, each TC gets 34 queues, vsi->num_txq will be 102 and only 102 queues
> will be enabled.
> 
> Signed-off-by: Usha Ketineni <usha.k.ketineni at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list