[Intel-wired-lan] [PATCH S33 04/15] ice: Don't modify stripping for add/del VLANs on VF

Bowers, AndrewX andrewx.bowers at intel.com
Tue Nov 12 19:32:00 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Friday, November 8, 2019 6:23 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S33 04/15] ice: Don't modify stripping for
> add/del VLANs on VF
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently when adding/deleting vlans in ice_vc_process_vlan_msg() we are
> calling ice_vsi_manage_vlan_stripping() to enable/disable when adding and
> deleting a VLAN respectively. This is wrong because adding/deleting VLANs
> has nothing to do with configuring VLAN stripping. VLAN stripping is
> configured through the following VIRTCHNL operations:
> 	VIRTCHNL_OP_ENABLE_VLAN_STRIPPING
> 	VIRTCHNL_OP_DISABLE_VLAN_STRIPPING
> 
> Unfortunately we can't just remove this because then stripping will never be
> configured on VF initialization. Fix this by adding a new function that initializes
> (disables/enables) VLAN stripping for the VF based on the device supported
> capabilities.
> This allows us to remove the call to
> ice_vsi_manage_vlan_stripping() in ice_vc_process_vlan_msg().
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
>  .../net/ethernet/intel/ice/ice_virtchnl_pf.c  | 39 +++++++++++++++----
>  1 file changed, 31 insertions(+), 8 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list