[Intel-wired-lan] [PATCH S33 09/15] ice: Do not use devm* functions for local uses

Bowers, AndrewX andrewx.bowers at intel.com
Tue Nov 12 19:34:33 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Friday, November 8, 2019 6:23 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S33 09/15] ice: Do not use devm* functions
> for local uses
> 
> In situations where we alloc and free memory within the same function do
> not use the devm_* variants; use regular alloc and free functions. Remove
> any unused vars if there are no usages after these changes.
> 
> Also, replace an allocate and copy with kmemdup() and remove an
> unnecessary memset() to 0 after a kzalloc().
> 
> Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.c  | 25 +++++----
> drivers/net/ethernet/intel/ice/ice_ethtool.c  | 50 ++++++++---------
>  drivers/net/ethernet/intel/ice/ice_lib.c      | 54 +++++++++----------
>  drivers/net/ethernet/intel/ice/ice_main.c     | 24 ++++-----
>  .../net/ethernet/intel/ice/ice_virtchnl_pf.c  | 15 +++---
>  5 files changed, 80 insertions(+), 88 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list