[Intel-wired-lan] [PATCH S33 14/15] ice: remove pointless NULL check of port_info

Bowers, AndrewX andrewx.bowers at intel.com
Tue Nov 12 19:36:55 UTC 2019


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Friday, November 8, 2019 6:24 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S33 14/15] ice: remove pointless NULL
> check of port_info
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> The code in ice_sched_cleanup_all checks whether the port info is NULL prior
> to calling ice_sched_clear_port. However, ice_sched_clear_port already
> checks whether port info is non-NULL.
> 
> More importantly, it also checks whether the port structure has been
> initialized by checking its port_state field as well.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_sched.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list