[Intel-wired-lan] [PATCH net 03/13] mv88e6xxx: reject unsupported external timestamp flags

[Keller, Jacob E]

> -----Original Message-----
> From: Richard Cochran <richardcochran at gmail.com>
> Sent: Thursday, November 14, 2019 10:45 AM
> To: netdev at vger.kernel.org
> Cc: intel-wired-lan at lists.osuosl.org; David Miller <davem at davemloft.net>;
> Brandon Streiff <brandon.streiff at ni.com>; Hall, Christopher S
> <christopher.s.hall at intel.com>; Eugenia Emantayev <eugenia at mellanox.com>;
> Felipe Balbi <felipe.balbi at linux.intel.com>; Feras Daoud
> <ferasda at mellanox.com>; Keller, Jacob E <jacob.e.keller at intel.com>; Kirsher,
> Jeffrey T <jeffrey.t.kirsher at intel.com>; Sergei Shtylyov
> <sergei.shtylyov at cogentembedded.com>; Stefan Sorensen
> <stefan.sorensen at spectralink.com>
> Subject: [PATCH net 03/13] mv88e6xxx: reject unsupported external timestamp
> flags
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Fix the mv88e6xxx PTP support to explicitly reject any future flags that
> get added to the external timestamp request ioctl.
> 
> In order to maintain currently functioning code, this patch accepts all
> three current flags. This is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.
> 
> For the record, the semantics of this driver are:
> 
>   flags                                                 Meaning
>   ----------------------------------------------------  --------------------------
>   PTP_ENABLE_FEATURE                                    Time stamp falling edge

For the new version of the ioctl this isn't possible, but we still support the v1 ioctl which would still have this mode. Ok.

>   PTP_ENABLE_FEATURE|PTP_RISING_EDGE                    Time stamp rising edge
>   PTP_ENABLE_FEATURE|PTP_FALLING_EDGE                   Time stamp falling edge
>   PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE   Time stamp
> rising edge
> 

Thanks,
Jake