[Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select bitmap validation

[Brandeburg, Jesse]

Brett is out on vacation but you’re right Andrew, the code should use plural variables. 

--
Jesse Brandeburg


> On Nov 15, 2019, at 16:08, Bowers, AndrewX <andrewx.bowers at intel.com> wrote:
> 
> I was getting the same thing. Taking the compiler's suggestion and changing _queue to _queues and it compiles but nobody responded to my comments. 
> 
>> -----Original Message-----
>> From: Brown, Aaron F
>> Sent: Friday, November 15, 2019 3:53 PM
>> To: Bowers, AndrewX <andrewx.bowers at intel.com>; Kirsher, Jeffrey T
>> <jeffrey.t.kirsher at intel.com>; intel-wired-lan at lists.osuosl.org
>> Cc: Creeley, Brett <brett.creeley at intel.com>; Arkady Gilinksky
>> <arkady.gilinsky at harmonicinc.com>
>> Subject: RE: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select bitmap
>> validation
>> 
>> This patch is causing a compile error for me.  If I pop revert it my compile
>> error goes away:
>> ---------------------------------------------------------------
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function
>> 'i40e_vc_validate_vqs_bitmaps':
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:2333:9: error: 'struct
>> virtchnl_queue_select' has no member named 'rx_queue'
>>      vqs->rx_queue >= BIT(I40E_MAX_VF_QUEUES) ||
>>         ^
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:2334:9: error: 'struct
>> virtchnl_queue_select' has no member named 'tx_queue'
>>      vqs->tx_queue >= BIT(I40E_MAX_VF_QUEUES))
>>         ^
>> make[6]: *** [drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.o] Error 1
>> make[6]: *** Waiting for unfinished jobs....
>> make[5]: *** [drivers/net/ethernet/intel/i40e] Error 2
>> make[4]: *** [drivers/net/ethernet/intel] Error 2
>> make[4]: *** Waiting for unfinished jobs....
>> make[3]: *** [drivers/net/ethernet] Error 2
>> make[2]: *** [drivers/net] Error 2
>> make[1]: *** [drivers] Error 2
>> make: *** [sub-make] Error 2
>> 
>>> -----Original Message-----
>>> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
>>> Of Bowers, AndrewX
>>> Sent: Thursday, November 14, 2019 5:17 PM
>>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>; intel-wired-
>>> lan at lists.osuosl.org
>>> Cc: Creeley, Brett <brett.creeley at intel.com>; Arkady Gilinksky
>>> <arkady.gilinsky at harmonicinc.com>
>>> Subject: Re: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select
>>> bitmap validation
>>> 
>>> Comments inline
>>> 
>>>> -----Original Message-----
>>>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
>>>> Behalf Of Jeff Kirsher
>>>> Sent: Wednesday, November 13, 2019 11:28 AM
>>>> To: intel-wired-lan at lists.osuosl.org
>>>> Cc: Creeley, Brett <brett.creeley at intel.com>; Arkady Gilinksky
>>>> <arkady.gilinsky at harmonicinc.com>
>>>> Subject: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select
>>>> bitmap validation
>>>> 
>>>> From: Brett Creeley <brett.creeley at intel.com>
>>>> 
>>>> Currently in i40e_vc_disable_queues_msg() we are incorrectly
>>>> validating
>>> the
>>>> virtchnl queue select bitmaps. The virtchnl_queue_select rx_queues
>>>> and tx_queue bitmap is being compared against ICE_MAX_VF_QUEUES,
>> but
>>> the
>>>> problem is that these bitmaps can have a value greater than
>>>> I40E_MAX_VF_QUEUES.
>>>> Fix this by comparing the bitmaps against BIT(I40E_MAX_VF_QUEUES).
>>>> 
>>>> Also, add the function i40e_vc_validate_vqs_bitmaps() that checks to
>>>> see if both virtchnl_queue_select bitmaps are empty along with
>>>> checking that
>>> the
>>>> bitmaps only have valid bits set. This function can then be used in
>>>> both the queue enable and disable flows.
>>>> 
>>>> Suggested-by: Arkady Gilinksky <arkady.gilinsky at harmonicinc.com>
>>>> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
>>>> ---
>>>> .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 22 +++++++++++++++----
>>>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>>> 
>> <snip>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan