[Intel-wired-lan] [PATCH net 1/2] i40e: need_wakeup flag might not be set for Tx

Maxim Mikityanskiy maximmi at mellanox.com
Mon Nov 25 15:24:33 UTC 2019


Hi Magnus,

On 2019-11-08 21:58, Magnus Karlsson wrote:
> This happens if there is at least one
> outstanding packet that has not been completed by the hardware and we
> get that corresponding completion (which will not generate an
> interrupt since interrupts are disabled in the napi poll loop) between
> the time we stopped processing the Tx completions and interrupts are
> enabled again.

> But if this completion interrupt occurs before interrupts
> are enable, we lose it
Why can't it happen for regular traffic? From your description it looks 
to me as if you can miss a completion for non-AF_XDP traffic, too. Is 
there any detail that makes this issue AF_XDP-specific?

Thanks,
Max


More information about the Intel-wired-lan mailing list