[Intel-wired-lan] [PATCH S35 13/15] ice: add extra check for null rx descriptor
andrewx.bowers at intel.com
Wed Dec 18 22:32:55 UTC 2019
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Thursday, December 12, 2019 3:13 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S35 13/15] ice: add extra check for null rx
> From: Mitch Williams <mitch.a.williams at intel.com>
> In the case where the hardware gives us a null rx descriptor, it is theoretically
> possible that we could call one of our skb-construction functions with no data
> pointer, which would cause a panic.
> In real life, this will never happen - we only get null RX descriptors as the final
> descriptor in a chain of otherwise-valid descriptors. When this happens, the
> skb will be extant and we'll just call ice_add_rx_frag(), which can deal with
> empty data buffers.
> Unfortunately, Coverity does not have intimate knowledge of our hardware,
> so we must add a check here.
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> drivers/net/ethernet/intel/ice/ice_txrx.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan