[Intel-wired-lan] [PATCH S35 15/15] ice: Suppress Coverity warnings for xdp_rxq_info_reg
andrewx.bowers at intel.com
Wed Dec 18 22:34:35 UTC 2019
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Thursday, December 12, 2019 3:13 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S35 15/15] ice: Suppress Coverity warnings
> for xdp_rxq_info_reg
> From: Krzysztof Kazimierczak <krzysztof.kazimierczak at intel.com>
> Coverity reports some of the calls to xdp_rxq_info_reg() as potential issues,
> because the driver does not check its return value. However, those calls are
> wrapped with "if (!xdp_rxq_info_is_reg(&ring->xdp_rxq))"
> and this check alone is enough to be sure that the function will never fail.
> All possible states of xdp_rxq_info are:
> - NEW,
> - REGISTERED,
> - UNREGISTERED,
> - UNUSED.
> The driver won't mark a queue as UNUSED under no circumstance, so the
> return value can be ignored safely.
> Add comments for Coverity right above calls to xdp_rxq_info_reg() to
> suppress the warnings.
> Signed-off-by: Krzysztof Kazimierczak <krzysztof.kazimierczak at intel.com>
> drivers/net/ethernet/intel/ice/ice_base.c | 2 ++
> 1 file changed, 2 insertions(+)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan