[Intel-wired-lan] [PATCH v2] fm10k: use txqueue parameter in fm10k_tx_timeout

Bowers, AndrewX andrewx.bowers at intel.com
Mon Jan 6 20:19:23 UTC 2020


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Thursday, December 19, 2019 12:10 PM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH v2] fm10k: use txqueue parameter in
> fm10k_tx_timeout
> 
> Make use of the new txqueue parameter to the .ndo_tx_timeout function.
> In fm10k_tx_timeout, remove the now unnecessary loop to determine
> which Tx queue is stuck. Instead, just double check the specified queue
> 
> This could be improved further to attempt resetting only the specific queue
> that got stuck. However, that is a much larger refactor and has been left as a
> future improvement.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
> 
> Woops, sorry for the quick v2. Had missed a semicolon and apparently my
> config I used to check this after a last minute move to add the Tx queue
> warning didn't have CONFIG_FM10K enabled.. Woops.
> 
>  drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list