[Intel-wired-lan] [PATCH] e1000e: fix missing cpu_to_le64 on buffer_addr

Brown, Aaron F aaron.f.brown at intel.com
Thu Jan 9 00:50:16 UTC 2020


> From: netdev-owner at vger.kernel.org <netdev-owner at vger.kernel.org>
> On Behalf Of Ben Dooks (Codethink)
> Sent: Wednesday, December 18, 2019 1:53 AM
> To: ben.dooks at codethink.co.uk
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>; David S. Miller
> <davem at davemloft.net>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org
> Subject: [PATCH] e1000e: fix missing cpu_to_le64 on buffer_addr
> 
> The following warning suggests there is a missing cpu_to_le64() in
> the e1000_flush_tx_ring() function (it is also the behaviour
> elsewhere in the driver to do cpu_to_le64() on the buffer_addr
> when setting it)
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:3813:30: warning: incorrect
> type in assignment (different base types)
> drivers/net/ethernet/intel/e1000e/netdev.c:3813:30:    expected restricted
> __le64 [usertype] buffer_addr
> drivers/net/ethernet/intel/e1000e/netdev.c:3813:30:    got unsigned long
> long [usertype] dma
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks at codethink.co.uk>
> ---
> Cc: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Aaron Brown <aaron.f.brown at intel.com>


More information about the Intel-wired-lan mailing list