[Intel-wired-lan] [PATCH 3/4] devlink: add support for triggering snapshots from userspace
Jacob Keller
jacob.e.keller at intel.com
Thu Jan 9 01:08:18 UTC 2020
Currently, devlink region snapshots are captured by the driver at some
internal trigger. There is no standard method for userspace to request
that a snapshot be created.
For some use cases of regions, this is acceptable. The snapshots only
make sense if taken in response to some internal driver event.
However, regions could be used for other purposes. For example, a driver
might export a region that represents the contents of some portion of
the device flash. In this case, there is no event that triggers
a snapshot. Instead, it makes sense for user space to request a snapshot
in some manner.
Currently, drivers must implement such a trigger through an out-of-band
mechanism. The netdevsim driver does this through a debugfs file.
Create a standard interface for requesting snapshots via a new devlink
command: DEVLINK_CMG_REGION_TRIGGER_SNAPSHOT.
At region creation time, drivers may optionally define
a trigger_snapshot function callback. If not defined, the
DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT will simply report EOPNOTSUPP.
If defined, the command will call the trigger_snapshot function
callback, resulting in a new snapshot being created.
With this, there is a standard mechanism for requesting new snapshots of
a given devlink region.
Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
---
drivers/net/ethernet/mellanox/mlx4/crdump.c | 4 +-
drivers/net/netdevsim/dev.c | 37 +++++++++++++-----
include/net/devlink.h | 12 ++++--
include/uapi/linux/devlink.h | 2 +
net/core/devlink.c | 43 +++++++++++++++++++--
5 files changed, 78 insertions(+), 20 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c b/drivers/net/ethernet/mellanox/mlx4/crdump.c
index 64ed725aec28..4b1373414b0b 100644
--- a/drivers/net/ethernet/mellanox/mlx4/crdump.c
+++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c
@@ -207,7 +207,7 @@ int mlx4_crdump_init(struct mlx4_dev *dev)
devlink_region_create(devlink,
region_cr_space_str,
MAX_NUM_OF_DUMPS_TO_STORE,
- pci_resource_len(pdev, 0));
+ pci_resource_len(pdev, 0), NULL);
if (IS_ERR(crdump->region_crspace))
mlx4_warn(dev, "crdump: create devlink region %s err %ld\n",
region_cr_space_str,
@@ -218,7 +218,7 @@ int mlx4_crdump_init(struct mlx4_dev *dev)
devlink_region_create(devlink,
region_fw_health_str,
MAX_NUM_OF_DUMPS_TO_STORE,
- HEALTH_BUFFER_SIZE);
+ HEALTH_BUFFER_SIZE, NULL);
if (IS_ERR(crdump->region_fw_health))
mlx4_warn(dev, "crdump: create devlink region %s err %ld\n",
region_fw_health_str,
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index 4b39aba2e9c4..4ed9c8d8de7c 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -38,30 +38,46 @@ static struct dentry *nsim_dev_ddir;
#define NSIM_DEV_DUMMY_REGION_SIZE (1024 * 32)
-static ssize_t nsim_dev_take_snapshot_write(struct file *file,
- const char __user *data,
- size_t count, loff_t *ppos)
+static int nsim_dev_trigger_snapshot(struct devlink *devlink,
+ struct devlink_region *region,
+ struct netlink_ext_ack *extack)
{
- struct nsim_dev *nsim_dev = file->private_data;
void *dummy_data;
int err;
u32 id;
dummy_data = kmalloc(NSIM_DEV_DUMMY_REGION_SIZE, GFP_KERNEL);
- if (!dummy_data)
+ if (!dummy_data) {
+ NL_SET_ERR_MSG(extack, "Out of memory");
return -ENOMEM;
+ }
get_random_bytes(dummy_data, NSIM_DEV_DUMMY_REGION_SIZE);
- id = devlink_region_snapshot_id_get(priv_to_devlink(nsim_dev));
- err = devlink_region_snapshot_create(nsim_dev->dummy_region,
- dummy_data, id, kfree);
+ id = devlink_region_snapshot_id_get(devlink);
+ err = devlink_region_snapshot_create(region, dummy_data, id, kfree);
if (err) {
- pr_err("Failed to create region snapshot\n");
+ NL_SET_ERR_MSG(extack, "Failed to create region snapshot");
kfree(dummy_data);
return err;
}
+ return (0);
+
+}
+
+static ssize_t nsim_dev_take_snapshot_write(struct file *file,
+ const char __user *data,
+ size_t count, loff_t *ppos)
+{
+ struct nsim_dev *nsim_dev = file->private_data;
+ int err;
+
+ err = nsim_dev_trigger_snapshot(priv_to_devlink(nsim_dev),
+ nsim_dev->dummy_region, NULL);
+ if (err)
+ return err;
+
return count;
}
@@ -248,7 +264,8 @@ static int nsim_dev_dummy_region_init(struct nsim_dev *nsim_dev,
nsim_dev->dummy_region =
devlink_region_create(devlink, "dummy",
NSIM_DEV_DUMMY_REGION_SNAPSHOT_MAX,
- NSIM_DEV_DUMMY_REGION_SIZE);
+ NSIM_DEV_DUMMY_REGION_SIZE,
+ nsim_dev_trigger_snapshot);
return PTR_ERR_OR_ZERO(nsim_dev->dummy_region);
}
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 38b4acb93f74..f93b1a07c9f2 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -491,6 +491,10 @@ struct devlink_info_req;
typedef void devlink_snapshot_data_dest_t(const void *data);
+typedef int devlink_trigger_snapshot_t(struct devlink *devlink,
+ struct devlink_region *region,
+ struct netlink_ext_ack *extack);
+
struct devlink_fmsg;
struct devlink_health_reporter;
@@ -933,10 +937,10 @@ void devlink_port_param_value_changed(struct devlink_port *devlink_port,
u32 param_id);
void devlink_param_value_str_fill(union devlink_param_value *dst_val,
const char *src);
-struct devlink_region *devlink_region_create(struct devlink *devlink,
- const char *region_name,
- u32 region_max_snapshots,
- u64 region_size);
+struct devlink_region *
+devlink_region_create(struct devlink *devlink, const char *region_name,
+ u32 region_max_snapshots, u64 region_size,
+ devlink_trigger_snapshot_t *trigger_snapshot);
void devlink_region_destroy(struct devlink_region *region);
u32 devlink_region_snapshot_id_get(struct devlink *devlink);
int devlink_region_snapshot_create(struct devlink_region *region,
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index ae37fd4d194a..19bec058691d 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -117,6 +117,8 @@ enum devlink_command {
DEVLINK_CMD_TRAP_GROUP_NEW,
DEVLINK_CMD_TRAP_GROUP_DEL,
+ DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT,
+
/* add new commands above here */
__DEVLINK_CMD_MAX,
DEVLINK_CMD_MAX = __DEVLINK_CMD_MAX - 1
diff --git a/net/core/devlink.c b/net/core/devlink.c
index b6fc67dbd612..ffc87dd54dbd 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -349,6 +349,7 @@ struct devlink_region {
u32 max_snapshots;
u32 cur_snapshots;
u64 size;
+ devlink_trigger_snapshot_t *trigger_snapshot;
};
struct devlink_snapshot {
@@ -4052,6 +4053,30 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,
return err;
}
+static int devlink_nl_cmd_region_trigger_snapshot(struct sk_buff *skb,
+ struct genl_info *info)
+{
+ struct devlink *devlink = info->user_ptr[0];
+ struct devlink_region *region;
+ const char *region_name;
+ struct sk_buff *msg;
+ u32 snapshot_id;
+ int err;
+
+ if (!info->attrs[DEVLINK_ATTR_REGION_NAME])
+ return -EINVAL;
+
+ region_name = nla_data(info->attrs[DEVLINK_ATTR_REGION_NAME]);
+ region = devlink_region_get_by_name(devlink, region_name);
+ if (!region)
+ return -EINVAL;
+
+ if (!region->trigger_snapshot)
+ return -EOPNOTSUPP;
+
+ return region->trigger_snapshot(devlink, region, info->extack);
+}
+
struct devlink_info_req {
struct sk_buff *msg;
};
@@ -6158,6 +6183,14 @@ static const struct genl_ops devlink_nl_ops[] = {
.flags = GENL_ADMIN_PERM,
.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK,
},
+ {
+ .cmd = DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT,
+ .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+ .doit = devlink_nl_cmd_region_trigger_snapshot,
+ .flags = GENL_ADMIN_PERM,
+ .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK |
+ DEVLINK_NL_FLAG_NO_LOCK,
+ },
{
.cmd = DEVLINK_CMD_INFO_GET,
.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -7499,11 +7532,12 @@ EXPORT_SYMBOL_GPL(devlink_param_value_str_fill);
* @region_name: region name
* @region_max_snapshots: Maximum supported number of snapshots for region
* @region_size: size of region
+ * @trigger_snapshot: function to trigger creation of snapshot
*/
-struct devlink_region *devlink_region_create(struct devlink *devlink,
- const char *region_name,
- u32 region_max_snapshots,
- u64 region_size)
+struct devlink_region *
+devlink_region_create(struct devlink *devlink, const char *region_name,
+ u32 region_max_snapshots, u64 region_size,
+ devlink_trigger_snapshot_t *trigger_snapshot)
{
struct devlink_region *region;
int err = 0;
@@ -7525,6 +7559,7 @@ struct devlink_region *devlink_region_create(struct devlink *devlink,
region->max_snapshots = region_max_snapshots;
region->name = region_name;
region->size = region_size;
+ region->trigger_snapshot = trigger_snapshot;
INIT_LIST_HEAD(®ion->snapshot_list);
list_add_tail(®ion->list, &devlink->region_list);
devlink_nl_region_notify(region, NULL, DEVLINK_CMD_REGION_NEW);
--
2.25.0.rc1
More information about the Intel-wired-lan
mailing list