[Intel-wired-lan] [PATCH v1] igc: Complete to commit Add basic skeleton for PTP

Vinicius Costa Gomes vinicius.gomes at intel.com
Tue Jan 21 21:59:04 UTC 2020

Hi Sasha,

Sasha Neftin <sasha.neftin at intel.com> writes:

> commit 5f2958052c58 ("igc: Add basic skeleton for PTP")
> Add ptp suspend method to the igc_shutdown.

I guess the commit message could use a bit more text, something like

"Commit 5f2958052c58 ("igc: Add basic skeleton for PTP") added basic
support for PTP, what's missing is support for suspending. By cleaning
the runtime storage for timestamp this avoids a possible invalid memory
access when the system comes back from suspend."

Apart from that, the code looks good.

Is this the only thing missing for suspend/resume to work? If so, that's
cool :-)


More information about the Intel-wired-lan mailing list