[Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment

Vinicius Costa Gomes vinicius.gomes at intel.com
Tue Jan 21 22:26:55 UTC 2020


Hi Sasha,

Sasha Neftin <sasha.neftin at intel.com> writes:

> Fix the typo and comment to correspond to the i225 device
> v1->v2:
> Address community comment
>
> Signed-off-by: Sasha Neftin <sasha.neftin at intel.com>
> ---
>  drivers/net/ethernet/intel/igc/igc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
> index 5d38d0faeced..cb1362188c2a 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -112,7 +112,7 @@ extern char igc_driver_version[];
>  #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
>  
>  /* Transmit and receive latency (for PTP timestamps) */
> -/* FIXME: These values were estimated using the ones that i210 has as
> +/* FIXME: These values were estimated using the ones that i225 has as
>   * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
>   * need to confirm them.
>   */

If you are sending this patch, it means that I couldn't explain myself
well enough. The idea of that comment was to point out that the
documentation doesn't provide an estimate of those values, so I used the
ones from the i210 datasheet.


Cheers,
--
Vinicius


More information about the Intel-wired-lan mailing list