[Intel-wired-lan] [PATCH v1] igc: Complete to commit Add basic skeleton for PTP

Neftin, Sasha sasha.neftin at intel.com
Wed Jan 22 06:28:41 UTC 2020

On 1/21/2020 23:59, Vinicius Costa Gomes wrote:
> Hi Sasha,
> Sasha Neftin <sasha.neftin at intel.com> writes:
>> commit 5f2958052c58 ("igc: Add basic skeleton for PTP")
>> Add ptp suspend method to the igc_shutdown.
> I guess the commit message could use a bit more text, something like
> this:
> "Commit 5f2958052c58 ("igc: Add basic skeleton for PTP") added basic
> support for PTP, what's missing is support for suspending. By cleaning
> the runtime storage for timestamp this avoids a possible invalid memory
> access when the system comes back from suspend."
Thanks Vinicius - I will extend the commit message in v2.
> Apart from that, the code looks good.
> Is this the only thing missing for suspend/resume to work? If so, that's
> cool :-)
> Cheers,
> --
> Vinicius

More information about the Intel-wired-lan mailing list