[Intel-wired-lan] [PATCH S38 04/15] ice: Fix Port VLAN priority bits

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, January 22, 2020 7:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S38 04/15] ice: Fix Port VLAN priority bits
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently when configuring a port VLAN for a VF we are only shifting the QoS
> bits by 12. This is incorrect. Fix this by getting rid of the ICE specific VLAN
> defines and use the kernel VLAN defines instead.
> 
> Also, don't assign a value to vlanprio until the VLAN ID and QoS parameters
> have been validated.
> 
> Also, there are many places we do (le16_to_cpu(vsi->info.pvid) &
> VLAN_VID_MASK). Instead do (vf->port_vlan_info & VLAN_VID_MASK)
> because we always save what's stored in vsi->info.pvid to vf->port_vlan_info
> in the CPU's endianness.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
>  .../net/ethernet/intel/ice/ice_virtchnl_pf.c  | 27 +++++++++----------
> .../net/ethernet/intel/ice/ice_virtchnl_pf.h  |  5 ----
>  2 files changed, 13 insertions(+), 19 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>